Skip to content

ci: delegate Ubuntu testing to Aspect Workflows, simplify GitHub Actions#193

Merged
acozzette merged 1 commit into
aspect-build:mainfrom
acozzette:ci
May 11, 2026
Merged

ci: delegate Ubuntu testing to Aspect Workflows, simplify GitHub Actions#193
acozzette merged 1 commit into
aspect-build:mainfrom
acozzette:ci

Conversation

@acozzette
Copy link
Copy Markdown
Contributor

Aspect Workflows already runs all Bazel versions across all workspaces on Linux, so the GHA Ubuntu matrix was redundant. GitHub Actions now only handles Mac/Windows smoke tests (gated to main), semantic PR validation, and a stable conclusion job for branch protection.

Also adds --config=ci globally in the Aspect Workflows config to activate CI-specific flags from tools/preset.bazelrc, and adds task IDs (bazel-7/8/9) to enable per-workspace overrides.

This aligns with the pattern we use for rules_js.


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@aspect-workflows
Copy link
Copy Markdown

aspect-workflows Bot commented May 11, 2026

Bazel 7 (Test)

5 test targets passed

Targets
//webpack/tests/devtool-override:write_bundle_test [k8-fastbuild]            70ms
//webpack/tests/simple:bundle_no_execroot_entry_point_matches [k8-fastbuild] 52ms
//webpack/tests/simple:entries_match [k8-fastbuild]                          45ms
//webpack/tests/simple:write_bundle_test [k8-fastbuild]                      55ms
//webpack/tests/worker:write_bundle_test [k8-fastbuild]                      22ms

Total test execution time was 244ms. 8 tests (61.5%) were fully cached saving 651ms.


Bazel 8 (Test)

All tests were cache hits

10 tests (100.0%) were fully cached saving 1s.


Bazel 9 (Test)

All tests were cache hits

10 tests (100.0%) were fully cached saving 1s.


Bazel 7 (Test)

e2e/loaders

1 test target passed

Targets
//:test [k8-fastbuild]                                                       34ms

Bazel 8 (Test)

e2e/loaders

All tests were cache hits

1 test (100.0%) was fully cached saving 36ms.


Bazel 9 (Test)

e2e/loaders

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 7 (Test)

e2e/loaders_jslib

1 test target passed

Targets
//:test [k8-fastbuild]                                                       27ms

Bazel 8 (Test)

e2e/loaders_jslib

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.


Bazel 9 (Test)

e2e/loaders_jslib

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.


Bazel 7 (Test)

e2e/smoke

2 test targets passed

Targets
//src:bundles_0_test [k8-fastbuild]                                          22ms
//src:bundles_1_test [k8-fastbuild]                                          65ms

Bazel 8 (Test)

e2e/smoke

All tests were cache hits

2 tests (100.0%) were fully cached saving 46ms.


Bazel 9 (Test)

e2e/smoke

All tests were cache hits

2 tests (100.0%) were fully cached saving 120ms.


Bazel 7 (Test)

e2e/worker

2 test targets passed

Targets
//:bundles_match [k8-fastbuild]                                              35ms
//:write_bundle_test [k8-fastbuild]                                          35ms

Bazel 8 (Test)

e2e/worker

All tests were cache hits

2 tests (100.0%) were fully cached saving 64ms.


Bazel 9 (Test)

e2e/worker

All tests were cache hits

2 tests (100.0%) were fully cached saving 67ms.


Buildifier

@acozzette acozzette marked this pull request as ready for review May 11, 2026 17:34
@acozzette acozzette requested a review from jbedard May 11, 2026 17:34
Aspect Workflows already runs all Bazel versions across all workspaces on
Linux, so the GHA ubuntu matrix was redundant. GitHub Actions now only
handles Mac/Windows smoke tests (gated to main), semantic PR validation,
and a stable conclusion job for branch protection.

Also adds --config=ci globally in the Aspect Workflows config to activate
CI-specific flags from tools/preset.bazelrc, and adds task IDs (bazel-7/8/9)
to enable per-workspace overrides.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jbedard
Copy link
Copy Markdown
Member

jbedard commented May 11, 2026

LGTM, but did you want to put macos in your branch name to verify this better?

@acozzette
Copy link
Copy Markdown
Contributor Author

Sure, let me create a new branch just for testing but I'll leave this one around so that you don't have to approve another PR.

@acozzette acozzette merged commit 4876cd7 into aspect-build:main May 11, 2026
11 checks passed
@acozzette acozzette deleted the ci branch May 11, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants