Update sphinx configuration to use new astropy-unified theme#3590
Update sphinx configuration to use new astropy-unified theme#3590Cadair wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3590 +/- ##
=======================================
Coverage 73.22% 73.23%
=======================================
Files 226 226
Lines 21000 21010 +10
=======================================
+ Hits 15378 15386 +8
- Misses 5622 5624 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bsipocz
left a comment
There was a problem hiding this comment.
Thanks @Cadair, this is long overdue!
@keflavich - I hold off merging to give you a chance to have a look, but overall I would say we merge and fix in follow-up if any issue pops up
|
Build preview is on the RTD status check here: https://astroquery--3590.org.readthedocs.build/en/3590/ That logo customisation isn't in the new theme. We could add a svg of it to the logo spot in the sidebar? |
|
ahh, this reminds me to circle back to the actual logo question. As for the colouring, I would agree that it would be nice to keep the customization even if it's just via an svg; the current theme is very very much astropy and I don't actually want to loose the branding of astroquery. |
|
(I don't mind the top bar, but actually do mind that it only says astropy ) |
|
ditto, I'd like to keep astroquery branding, so please hold off on merging this until we have created the svg logo. Can we do that trivially from the old theme? |
we agreed to do some tweaks before merging, so I'm flipping this status to red to make sure we don't accidentally merge.
bsipocz
left a comment
There was a problem hiding this comment.
OK, let's hold off until we figure out how to make the astroquery branding more prominent than the top level heading's astropy one.
|
We could do something like this on photutils:
Put a logo up on the left sidebar? |
|
can try this. If it works, where do we put it? Putting the logo below is... fine, I guess? But I like the docs as they are now, I don't like arbitrary change. |
|
(I haven't played with the above at all; the font families are just ai-gen, but they're close to what we have now: |
|
Do you want to keep the |
|
the last thing you posted is good - if we can have that sitting in the top left, I'm happy enough, I spose. |
|
Ok, see last commit. I added it to the top of the index page as well. |
|
https://astroquery--3590.org.readthedocs.build/en/3590/ Thanks for adding that @Cadair . I still don't love the aesthetics right now.... there's redundant labeling all around. I like astroquery's current more minimal look. |
|
oh man, you don't have the font for that logo installed 🙈 So remove it from the index page and just leave it in the sidebar? |
yeah I think so argh, fonts. |
|
How about now? I don't know what's up with the fonts? |
unfortunately we'll need to move on from that, we even have a (or more) many years old issue(s) for that. At some point Clara was about to change stuff but she also went nuclear with mixing theme changes with content rather than doing piecemeal so it couldn't be merged. |



This PR migrates this repo to use the new astropy-unified sphinx theme.
For more information about this project see astropy/astropy-project#522