Skip to content

Detect Pre-Release and Release Candidate versions #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavog merged 4 commits into from
Nov 20, 2025
Merged

Detect Pre-Release and Release Candidate versions #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a0c9ed
adjust regex to detect Pre-Release versions
pavog Nov 20, 2025
deaad1a
add test files for 1.21.11 Pre-Release 1
pavog Nov 20, 2025
98975e6
add "Release Candidate" to version pattern
pavog Nov 20, 2025
cd25543
add test file for 1.21.10 Release Candidate 1
pavog Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Analysis/Information/Vanilla/VanillaVersionInformation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

class VanillaVersionInformation extends VanillaInformation
{
protected static string $vanillaVersionPattern = '[0-9\.w]+(?:[a-z]|-(?:pre|rc)\d+)?';
protected static string $vanillaVersionPattern = '[0-9\.w]+(?:[a-z]|(?:-|\s)?(?:pre|rc|Pre-Release|Release Candidate)\s?\d+)?';

/**
* @inheritDoc
Expand All @@ -33,4 +33,4 @@ public function __construct()
{
$this->label = Translator::getInstance()->getTranslation("minecraft-version");
}
}
}
Loading