Improve socket:send/2,3 error handling for transient send backpressure#2345
Draft
harmon25 wants to merge 1 commit into
Draft
Improve socket:send/2,3 error handling for transient send backpressure#2345harmon25 wants to merge 1 commit into
harmon25 wants to merge 1 commit into
Conversation
Signed-off-by: harmon25 <dougwright1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the accuracy of error reporting in the socket send implementation, making it easier for callers to distinguish between transient backpressure and actual connection closure. The most important changes are:
Socket send error handling improvements:
src/libAtomVM/otp_socket.c: Now returns{error, eagain}when a send operation encounters transient backpressure (such as lwIPERR_MEMor BSDEAGAIN/EWOULDBLOCK), allowing callers to retry instead of misinterpreting it as a closed connection.src/libAtomVM/otp_socket.c: When the peer has closed the connection, returns{error, closed}instead of{ok, Data}to clarify the connection state.Documentation update:
CHANGELOG.md: Updated to reflect thatsocket:send/2,3now correctly differentiates between transient backpressure and closed connections in its error reporting.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later