Skip to content

Conversation

@isamu-takagi
Copy link
Contributor

Description

Add parameter for setting initial latch suppression status.

Related links

How was this PR tested?

  1. Add latch: 0.0 to a diag unit somewhere in the example.
  2. Run ros2 launch autoware_diagnostic_graph_aggregator example-main.launch.xml
  3. Run ros2 run autoware_diagnostic_graph_utils dump_node

Notes for reviewers

None.

Interface changes

ROS Parameter Changes

Change type Parameter Name Type Default Value Description
Added initial_latch_suppression bool true Whether to disable latch initially.

Effects on system behavior

Latch feature is disabled by default. It must be enabled by a service once the system is ready.

@isamu-takagi isamu-takagi self-assigned this Dec 3, 2025
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@sasakisasaki sasakisasaki added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 3, 2025
Copy link
Contributor

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isamu-takagi Thank you for update. Only one confirmation. Do we need to update autoware_launch side too?

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.97%. Comparing base (343a70f) to head (c9cf0cc).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...iagnostic_graph_aggregator/src/node/aggregator.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11715      +/-   ##
==========================================
+ Coverage   17.86%   17.97%   +0.11%     
==========================================
  Files        1747     1748       +1     
  Lines      122415   122451      +36     
  Branches    42929    42949      +20     
==========================================
+ Hits        21864    22007     +143     
- Misses      82238    82274      +36     
+ Partials    18313    18170     -143     
Flag Coverage Δ *Carryforward flag
daily 20.01% <ø> (ø) Carriedforward from 343a70f
daily-cuda 17.86% <ø> (ø) Carriedforward from 343a70f
differential 66.28% <0.00%> (?)
total-cuda 17.86% <ø> (ø) Carriedforward from 343a70f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

2 participants