Skip to content

Comments

feat: add dockerized testing#57

Merged
maxday merged 33 commits intomainfrom
maxday/add-dockerized-testing
Feb 24, 2026
Merged

feat: add dockerized testing#57
maxday merged 33 commits intomainfrom
maxday/add-dockerized-testing

Conversation

@maxday
Copy link
Member

@maxday maxday commented Feb 19, 2026

Description of changes:

Add harness testing on push, also adding the capabilithy of running harness test locally with make test-dockerized RUBY_VERSION=3.4 or make test-dockerized RUBY_VERSION=3.3

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Comment on lines 13 to 38
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
ruby_version: ['3.3', '3.4']

steps:
- uses: actions/checkout@v3

- name: Set up ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby_version }}

- name: Build the lib
run: make build

- name: Build the image
run: docker build . -t local/test -f Dockerfile.test --build-arg BASE_IMAGE=public.ecr.aws/lambda/ruby:${{ matrix.ruby_version }}

- name: Run tests
uses: aws/containerized-test-runner-for-aws-lambda@v1
with:
suiteFileArray: '["./test/dockerized/suites/*.json"]'
dockerImageName: 'local/test'
taskFolder: './test/dockerized/tasks'

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 5 days ago

In general, you fix this issue by explicitly declaring a permissions: block either at the top level of the workflow (applies to all jobs) or under the specific job, granting only the scopes needed (typically contents: read for basic CI). Since this workflow only checks out code, sets up Ruby, builds, and runs tests, it appears to need only read access to repository contents, so contents: read is an appropriate minimal permission.

The best fix without changing existing functionality is to add a root-level permissions: block right after the name: (line 1) and before the on: block (line 3). This keeps the job definition intact and ensures any future jobs in this workflow inherit the same minimal permissions unless they override them. Concretely, in .github/workflows/dockerized-test.yml, insert:

permissions:
  contents: read

on new lines between current lines 1 and 3 (shifting the rest down). No additional methods, imports, or definitions are needed: this is a pure workflow configuration change.

Suggested changeset 1
.github/workflows/dockerized-test.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/dockerized-test.yml b/.github/workflows/dockerized-test.yml
--- a/.github/workflows/dockerized-test.yml
+++ b/.github/workflows/dockerized-test.yml
@@ -1,5 +1,8 @@
 name: dockerized-test
 
+permissions:
+  contents: read
+
 on:
   push:
     branches: [ main ]
EOF
@@ -1,5 +1,8 @@
name: dockerized-test

permissions:
contents: read

on:
push:
branches: [ main ]
Copilot is powered by AI and may make mistakes. Always verify output.
@maxday maxday committed this autofix suggestion 5 days ago.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

maxday and others added 4 commits February 19, 2026 13:31
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@maxday maxday marked this pull request as ready for review February 20, 2026 15:40
@maxday maxday changed the title [WIP] add dockerized testing feat: add dockerized testing Feb 24, 2026
@maxday maxday merged commit 6e2c8ce into main Feb 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants