Skip to content

Conversation

@jakemas
Copy link
Collaborator

@jakemas jakemas commented Nov 25, 2025

Testing CI

Currently showing the last time windows-11-arm passed in CI to study what changed.

I expect failures related to the delocate.peg stuff, specifically ubuntu22:04, but we know the fix for that is to add it to SymbolOperator

Notes:

Delocator issues
Functions that require trampolines:

- `adr x23, .Laes_hw_encrypt_local_target` (line 48027)
- `adr x8, .Lvpaes_encrypt_local_target` (line 48076)
- `adr x8, .Lgcm_ghash_v8_local_target` (line 48132, 48170, 48228, 48397)
- `adr x9, .Lgcm_gmult_v8_local_target` (line 48134, 48172, 48230, 48399)
- `adr x0, .Lvpaes_ctr32_encrypt_blocks_local_target` (line 48141, 48296)
- `adr x0, .Laes_hw_ctr32_encrypt_blocks_local_target` (line 48198)
- `adr x8, .Lgcm_ghash_neon_local_target` (line 48183, 48241, 48286, 48410)
- `adr x9, .Lgcm_gmult_neon_local_target` (line 48185, 48243, 48288, 48412)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@jakemas jakemas changed the title Testingg Testing CI Nov 25, 2025
github-actions[bot]

This comment was marked as duplicate.

@jakemas jakemas force-pushed the mldsa-native-import branch from 73ba8f2 to 8bea153 Compare November 25, 2025 21:01
github-actions[bot]

This comment was marked as duplicate.

github-actions[bot]

This comment was marked as duplicate.

github-actions[bot]

This comment was marked as duplicate.

github-actions[bot]

This comment was marked as duplicate.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 87.78195% with 130 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.19%. Comparing base (31cb153) to head (9e615f5).

Files with missing lines Patch % Lines
crypto/fipsmodule/ml_dsa/mldsa/sign.c 63.63% 100 Missing ⚠️
crypto/fipsmodule/ml_dsa/ml_dsa.c 82.85% 18 Missing ⚠️
crypto/fipsmodule/ml_dsa/mldsa/poly.c 96.64% 5 Missing ⚠️
crypto/fipsmodule/cipher/e_aes.c 66.66% 3 Missing ⚠️
crypto/fipsmodule/aes/mode_wrappers.c 77.77% 2 Missing ⚠️
crypto/fipsmodule/ml_dsa/mldsa/packing.c 98.24% 1 Missing ⚠️
crypto/fipsmodule/ml_dsa/mldsa/poly_kl.c 99.49% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2865      +/-   ##
==========================================
- Coverage   78.24%   78.19%   -0.06%     
==========================================
  Files         683      687       +4     
  Lines      117374   117422      +48     
  Branches    16492    16496       +4     
==========================================
- Hits        91845    91815      -30     
- Misses      24644    24721      +77     
- Partials      885      886       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions[bot]

This comment was marked as duplicate.

@jakemas jakemas force-pushed the mldsa-native-import branch from 89dae6a to 79ee751 Compare November 25, 2025 23:49
github-actions[bot]

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants