Implement enc CLI #2877
Open
Implement enc CLI #2877
+588
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tool-openssl/enc.cc
Outdated
| uint8_t inbuf[1024]; | ||
| bssl::UniquePtr<uint8_t> outbuf( | ||
| (uint8_t *)OPENSSL_zalloc(1024 + EVP_CIPHER_block_size(cipher))); | ||
| int inlen, outlen; |
Contributor
There was a problem hiding this comment.
warning: variable 'inlen' is not initialized [cppcoreguidelines-init-variables]
Suggested change
| int inlen, outlen; | |
| int inlen = 0, outlen; |
tool-openssl/enc.cc
Outdated
| uint8_t inbuf[1024]; | ||
| bssl::UniquePtr<uint8_t> outbuf( | ||
| (uint8_t *)OPENSSL_zalloc(1024 + EVP_CIPHER_block_size(cipher))); | ||
| int inlen, outlen; |
Contributor
There was a problem hiding this comment.
warning: variable 'outlen' is not initialized [cppcoreguidelines-init-variables]
Suggested change
| int inlen, outlen; | |
| int inlen, outlen = 0; |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2877 +/- ##
==========================================
- Coverage 78.23% 78.23% -0.01%
==========================================
Files 683 685 +2
Lines 117412 117646 +234
Branches 16502 16535 +33
==========================================
+ Hits 91862 92038 +176
- Misses 24662 24723 +61
+ Partials 888 885 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
reviewed
Dec 4, 2025
tool-openssl/enc.cc
Outdated
| const EVP_CIPHER *cipher = EVP_get_cipherbyname(cipher_name.c_str()); | ||
|
|
||
| int iv_length = EVP_CIPHER_iv_length(cipher); | ||
| bssl::UniquePtr<uint8_t> iv((uint8_t *)OPENSSL_zalloc(EVP_MAX_IV_LENGTH)); |
Contributor
There was a problem hiding this comment.
Shouldn't these pointers be to arrays?
bssl::UniquePtr<uint8_t[]> iv((uint8_t *)OPENSSL_zalloc(EVP_MAX_IV_LENGTH));
| } else { | ||
| cipher_name = cipher_name.substr(1); | ||
| } | ||
| const EVP_CIPHER *cipher = EVP_get_cipherbyname(cipher_name.c_str()); |
Contributor
There was a problem hiding this comment.
Check for NULL.
if (cipher == nullptr) {
fprintf(stderr, "Error: Unknown cipher %s\n",
cipher_name.c_str());
return false;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Implement enc CLI with the following options:
Testing:
Unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.