Skip to content

fix missing pagination header installion#3722

Merged
sbiscigl merged 1 commit intomainfrom
pagination-headers
Feb 17, 2026
Merged

fix missing pagination header installion#3722
sbiscigl merged 1 commit intomainfrom
pagination-headers

Conversation

@sbiscigl
Copy link
Contributor

Description of changes:

we dont install the pagination headers merged in the related pagination pull request. this adds the installation.

tested by checking installation

~/aws-sdk-cpp ❯❯❯ ls /.../install/include/aws/core/utils/pagination
Paginator.h

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review February 16, 2026 22:14
@sbiscigl sbiscigl merged commit 175e803 into main Feb 17, 2026
6 checks passed
@sbiscigl sbiscigl deleted the pagination-headers branch February 17, 2026 00:20
@rok
Copy link

rok commented Feb 20, 2026

Just pinging from downstream. When do you expect the brew recipe will be updated?

@kou
Copy link

kou commented Feb 20, 2026

BrewTestBot will update the Homebrew recipe automatically: https://github.com/Homebrew/homebrew-core/pulls?q=is%3Apr+aws-sdk-cpp+is%3Aclosed

It seems that the Homebrew recipe is updated every about 3 weeks.

Or we can open a pull request manually by brew bump-formula-pr ... before the auto update.

@Anakin100100
Copy link

@kou Can we merge this? This issue causes the cicd to fail on some platforms https://github.com/apache/arrow/actions/runs/22318831466/job/64571281095?pr=49375

@kou
Copy link

kou commented Feb 24, 2026

Let's discuss Apache Arrow related things in apache/arrow such as apache/arrow#49347 not here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants