Open
Conversation
added 19 commits
January 21, 2026 10:29
xiazhvera
approved these changes
Feb 23, 2026
Contributor
xiazhvera
left a comment
xiazhvera
left a comment
There was a problem hiding this comment.
LGTM, some minor comments.
| /* | ||
| * [ConnNegativeID-UC4] Client connect with socket timeout | ||
| */ | ||
| static int s_TestMqtt5SocketTimeout(Aws::Crt::Allocator *allocator, void *) |
Contributor
There was a problem hiding this comment.
Why did we remove the socket timeout test? It was there to verify the failure path and that the error code was bound properly. I think it's still needed.
Contributor
Author
There was a problem hiding this comment.
It's not reliable in CI and I don't know of an endpoint we can use that would be reliable.
| ASSERT_TRUE(connection1Promise.get_future().get()); | ||
| ASSERT_TRUE(testContext1.connectionPromise.get_future().get()); | ||
|
|
||
| testContext1.connectionPromise = std::promise<bool>{}; |
Contributor
There was a problem hiding this comment.
It doesn't seem like we need to reset the promise for client1 again.
Contributor
Author
There was a problem hiding this comment.
It can be tripped and when it does it crashes the test.
added 2 commits
March 2, 2026 10:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors MQTT5 tests to
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.