-
Notifications
You must be signed in to change notification settings - Fork 38
Add AVX2 VPBLENDD instruction #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Having some issues with this one getting picked up correctly by |
|
Ok I think I got it! |
98e0978 to
dd13f57
Compare
|
In order to support When testing the instruction, I found that the existing tests might have some issues. |
|
Yes, I think @pennyannn's addition of the "msimd" constructs is a good idea, since these make the definition here quite clean and structurally similar to the others. If we add these here we can move them upstream into HOL Light at a later date. |
|
Hey - do you have any idea why the x86 cosimulator is failing? It hits this bytecode |
I'm confused, I ran a simple test, and the decoder picked it up as a VPBLENDD as intended: XMM cases failing, YMM cases working? Indicates my test cases are fine, the decoder is working, its a problem with the definition, working on that now (so far 30min cosimulating no issues). got it :) 01e778f |
aqjune-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that running the cosimulator with the new instruction patterns ran successfully.
Moved msimd* to common/words2.ml, and slightly increased the running times of arm/x86 cosimulators from 30 mins to 45 mins because both of these are having more patterns than before (when it was set to 30min :).
Issue #, if available:
N/A
Description of changes:
This change models the AVX2 Vector Packed Blend Doublewords (
VPBLENDD) instruction.Callouts:
I had to add a new section
| VEXM_0F3A ->withindecode.mlBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.