Add the safety properties of x86 mlkem_reduce for 4 variants (IBT x Windows) #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqjune-aws
force-pushed
the
consttime-x86-fnstack
branch
2 times, most recently
from
44349f5 to
b31bb02
Compare
…indows) This patch adds the safety properties of x86 mlkem_reduce for 4 variants: whether it has IBT or not, and whether it has Windows ABI or not. This also has a lot of changes that affect safety proofs other than x86 mlkem_reduce: - The name of PROVE_SAFETY_SPEC is changed to PROVE_SAFETY_SPEC_TAC - The theorem for weakly_valid_component of bytes256 was wrong; I fixed it. - The `mk_safety_spec` takes an extra argument for keeping the MAYCHANGE part of ensures. This is needed if the spec is going to be used for compositional reasoning.
aqjune-aws
force-pushed
the
consttime-x86-fnstack
branch
from
b31bb02 to
2a0240c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the safety properties of x86 mlkem_reduce for 4 variants: whether it has IBT or not, and whether it has Windows ABI or not.
This also has a lot of changes that affect safety proofs other than x86 mlkem_reduce:
mk_safety_spectakes an extra argument for keeping the MAYCHANGE part of ensures. This is needed if the spec is going to be used for compositional reasoning.Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.