Skip to content

Process parent records on join#204

Open
anotherpit wants to merge 2 commits into
balderdashy:masterfrom
anotherpit:patch-1
Open

Process parent records on join#204
anotherpit wants to merge 2 commits into
balderdashy:masterfrom
anotherpit:patch-1

Conversation

@anotherpit
Copy link
Copy Markdown

Currently find() uses processor to cast result records, and join() does not. This PR adds processing to parent records of join() results. Child records still need to be processed.

@devinivy
Copy link
Copy Markdown
Contributor

join() is often used internally– find would use it, but you'd never call it directly. Can you give an example of a failing case?

@particlebanana
Copy link
Copy Markdown
Contributor

Yes @anotherpit I need a failing test to show that this fixes it and so we don't get any regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants