Stop relying on customer fillable content to create s3 keys #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the filename on the s3 key is not a good idea as these can contain lots of weird characters and open ways for security breaches. The UUID should be enough to guarantee uniqueness on the keys and the fieldName should be enough to at least point to a direction on what this resource is. This is also not breaking as the href field of old webresources should still work fine but the new ones shall not use possibly skewed data. Change-type: patch
…ith original name Change-type: patch
otaviojacobi
force-pushed
the
stop-using-customer-property-on-s3-keys
branch
from
78ed8a7 to
63142d6
Compare
klutchell
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the filename on the s3 key is not a good idea as these can contain lots of weird characters and open ways for security breaches. The UUID should be enough to guarantee uniqueness on the keys and the fieldName should be enough to at least point to a direction on what this resource is.
This is also not breaking as the href field of old webresources should still work fine but the new ones shall not use possibly skewed data.
See: https://balena.fibery.io/search/DMBt7#Work/Improvement/Make-webresources-file-deletion-more-reliable-2819
Change-type: patch