fix: use dynamic import for useBus to support volume-mounted extensions#97
Open
alphanull wants to merge 1 commit intobcc-code:mainfrom
Open
fix: use dynamic import for useBus to support volume-mounted extensions#97alphanull wants to merge 1 commit intobcc-code:mainfrom
alphanull wants to merge 1 commit intobcc-code:mainfrom
Conversation
The static import of useBus from @directus/api requires the extension to be bundled into the Directus Docker image. By switching to a dynamic import wrapped in try/catch, the extension gracefully degrades when the internal API is unavailable (e.g. when loaded as a volume-mounted extension without a custom Dockerfile). Flow reload after import still works when running inside the official Directus image; it is silently skipped otherwise. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static import of useBus from @directus/api requires the extension to be bundled into the Directus Docker image. By switching to a dynamic import wrapped in try/catch, the extension gracefully degrades when the internal API is unavailable (e.g. when loaded as a volume-mounted extension without a custom Dockerfile).
Flow reload after import still works when running inside the official Directus image; it is silently skipped otherwise.
This makes it possible to run this as a regular extension if automatic flow reload is not an issue.