[Enhancement] Read config file from platform-specific config folder#839
Merged
bee-san merged 2 commits intobee-san:masterfrom Nov 27, 2025
Merged
[Enhancement] Read config file from platform-specific config folder#839bee-san merged 2 commits intobee-san:masterfrom
bee-san merged 2 commits intobee-san:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates RustScan's configuration file location from the user's home directory to platform-specific configuration directories using the dirs::config_dir() function. The change provides better adherence to OS-specific standards while maintaining backward compatibility.
- Uses
dirs::config_dir()for the new default config path (e.g.,~/.config/.rustscan.tomlon Linux) - Implements fallback logic to check the old home directory location if the new path doesn't exist
- Adds informational messages to notify users about both the primary and fallback config locations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/input.rs | Adds old_default_config_path() function, updates default_config_path() to use dirs::config_dir(), implements fallback logic in Config::read() |
| src/main.rs | Adds informational message about the old config path for backwards compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bee-san
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using
dirs::config_dir, we use a more common standard for finding/storing config files, one that doesn't pollute the end-user's home directory. Examples:I have kept the old path in the output messages and the code, for backwards compatibility, and if the config_dir doesn't have the config file, the code checks for the current solution
/home/$USER/.rustscan.toml.