Skip to content

Conversation

@JMS55
Copy link
Contributor

@JMS55 JMS55 commented Dec 24, 2025

I did a bunch of testing, and after recent rounds of improvements to specular GI, I don't think this is worth it anymore. Turning it off reduces light leaks with thin geometry.

@JMS55 JMS55 requested a review from SparkyPotato December 24, 2025 02:22
@JMS55 JMS55 added this to the 0.18 milestone Dec 24, 2025
@JMS55 JMS55 added A-Rendering Drawing game state to the screen C-Refinement Improves output quality, without fixing a clear bug or adding new functionality. labels Dec 24, 2025
@JMS55 JMS55 requested a review from alice-i-cecile December 24, 2025 02:24
@JMS55 JMS55 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 24, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 29, 2025
Merged via the queue into bevyengine:main with commit a7c236f Dec 29, 2025
43 checks passed
mockersf pushed a commit that referenced this pull request Dec 30, 2025
I did a bunch of testing, and after recent rounds of improvements to
specular GI, I don't think this is worth it anymore. Turning it off
reduces light leaks with thin geometry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Refinement Improves output quality, without fixing a clear bug or adding new functionality. S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants