Fix Updated images occasionally never displayed on materials by ensuring correct ordering of system sets #22255
+27
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsDoot
added
C-Bug
Member
It wouldn't really be useful for users as an example, and we should avoid adding test examples as it has a negative impact on contributors. Could we add a unit test on schedule ordering? |
mockersf
approved these changes
Dec 24, 2025
IceSentry
approved these changes
Dec 29, 2025
Contributor
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
I can confirm it fixes the linked issue
alice-i-cecile
added
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Dec 30, 2025
alice-i-cecile
changed the title
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
# Objective - Fixes #22212 ## Solution Replace `HashSet` usage with `IndexSet` in `DagGroups` to maintain insertion order like the previous `Vec` implementation. ## Testing Used the provided example in the bug report. Should we add it as a test or example somewhere?
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
# Objective - Fixes #22212 ## Solution Replace `HashSet` usage with `IndexSet` in `DagGroups` to maintain insertion order like the previous `Vec` implementation. ## Testing Used the provided example in the bug report. Should we add it as a test or example somewhere?
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
# Objective - Fixes #22212 ## Solution Replace `HashSet` usage with `IndexSet` in `DagGroups` to maintain insertion order like the previous `Vec` implementation. ## Testing Used the provided example in the bug report. Should we add it as a test or example somewhere?
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
# Objective - Fixes #22212 ## Solution Replace `HashSet` usage with `IndexSet` in `DagGroups` to maintain insertion order like the previous `Vec` implementation. ## Testing Used the provided example in the bug report. Should we add it as a test or example somewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Replace
HashSetusage withIndexSetinDagGroupsto maintain insertion order like the previousVecimplementation.Testing
Used the provided example in the bug report. Should we add it as a test or example somewhere?