Add missing volume mounts for coturn and redis#370
Merged
alangecker merged 1 commit intobigbluebutton:developfrom Jan 7, 2026
Merged
Add missing volume mounts for coturn and redis#370alangecker merged 1 commit intobigbluebutton:developfrom
alangecker merged 1 commit intobigbluebutton:developfrom
Conversation
These directories were marked as volumes in their dockerfile, but nothing was explicitly mounted on them. This makes docker create an unnamed volume and mount that when the container is created, which means that on every down/up cycle, it would leave two unnamed volumes lingering around. Explicitly mounting these data directories prevents this.
Collaborator
|
ah, good point! I wasn't aware about that docker behavior. Thanks for the PR! |
Contributor
Author
|
Thanks! I actually recently came across this post, https://stackoverflow.com/a/62068396/740048, which argues to just not ever use VOLUME in your Dockerfile at all, because of this particularly (actually useless) behavior in docker. I'll leave that for your consideration :-) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These directories were marked as volumes in their dockerfile, but nothing was explicitly mounted on them. This makes docker create an unnamed volume and mount that when the container is created, which means that on every down/up cycle, it would leave two unnamed volumes lingering around.
Explicitly mounting these data directories prevents this.