Copilot/awesome ai drivendevelopment 101

[5hy7xz92nd-oss]

No description provided.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

Suppressed comments (3)

.github/instructions/*.instructions.md:5

• This file is committed with a literal * in its filename (.github/instructions/*.instructions.md). Filenames containing glob metacharacters commonly break shell tooling, scripts, and some editor integrations, and it also makes the intent of the instructions unclear. Consider renaming it to a concrete, descriptive filename (e.g. review.instructions.md) and trimming the content to actionable Copilot/repo guidance.

@5hy7xz92nd-oss @copilot @copilot @copilot @we-tech-company @copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
|
↓
👁️ Observer
|

validate_pocs.py:14

• tomllib is only available on Python 3.11+, so running this script with older python3 (e.g. 3.10) will fail at import time. Either document the minimum Python version explicitly or add a fallback to tomli with a clearer error message so local validation doesn't break unexpectedly.

import subprocess
import sys
import tomllib
from collections import Counter

README.md:83

• The local run instructions don't mention that validation (and the unit tests that call validate_repo) require Node.js to be installed, and the validator currently implies Python 3.11+ due to tomllib. Adding a short prerequisite note here will prevent confusing local failures.

Run locally:

```bash
python -m unittest discover -s tests -v
python validate_pocs.py

</details>

[Copilot]

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

Suppressed comments (6)

tests/test_validate_pocs.py:38

• This test also relies on large, repo-specific minimum counts that will become flaky as PoCs are added/removed. Consider asserting smaller lower bounds (or only the invariants you actually need here) and rely on the fixture-based tests for detailed validation behavior.

        self.assertGreater(result["python_files"], 20)
        self.assertGreater(result["package_json_files"], 0)
        self.assertGreaterEqual(result["cargo_toml_files"], 2)
        self.assertGreater(result["javascript_files"], 0)
        self.assertGreater(result["poc_directories"], 30)

tests/test_validate_pocs.py:29

• These hard-coded minimum counts (e.g., "> 20" Python files, "> 30" PoC dirs) are likely to fail as the repository contents change. Using small, intent-focused lower bounds keeps the test meaningful without being overly sensitive to future additions/removals.

        self.assertGreater(len(python_targets), 20)
        self.assertGreater(len(package_targets), 0)
        self.assertGreaterEqual(len(cargo_targets), 2)
        self.assertGreater(len(poc_dirs), 30)

.github/workflows/validate.yml:32

• The step name says "integrations", but this workflow is running repository integrity checks. Renaming avoids confusion when scanning workflow logs.

      - name: Validate repository integrations

.github/instructions/*.instructions.md:243

• This file looks like an accidental paste of PR timeline / Copilot review output (and contains a large amount of non-instruction content). Also, the filename contains *, which is invalid on Windows and can break checkouts and glob-based tooling. Please remove this file or replace it with a concise Copilot instructions document using a safe filename (e.g., .github/instructions/copilot.instructions.md).

            👁️ OBSERVE AGAIN 👁️ OBSERVE AGAIN 🌎 REALITY Reality provides signals.
@5hy7xz92nd-oss
5hy7xz92nd-oss marked this pull request as ready for review last week
5hy7xz92nd-oss
5hy7xz92nd-oss commented last week

tests/test_validate_pocs.py:25

• The discovery test is currently tied to specific repository files and content (e.g., run_demo.py). That makes the test brittle as PoC folders evolve. Prefer asserting stable invariants introduced by this PR (e.g., validate_pocs.py is discoverable) and basic non-emptiness for key target lists.

This issue also appears in the following locations of the same file:

• line 26
• line 34

        self.assertTrue(any(path.name == "run_demo.py" for path in python_targets))
        self.assertTrue(any(path.name == "package.json" for path in package_targets))
        self.assertTrue(any(path.name == "Cargo.toml" for path in cargo_targets))
        self.assertTrue(any(path.suffix == ".js" for path in js_targets))
        self.assertFalse(any(path.name == "package.json" for path in json_targets))

tests/test_validate_pocs.py:182

• validate_pocs.main() prints to stdout/stderr, so calling it directly in tests makes the unittest output noisy. Redirect stdout/stderr in this test so failures remain readable.

    def test_main_success_and_failure_exit_codes(self) -> None:
        self.assertEqual(validate_pocs.main(["--root", str(self.repo_root)]), 0)

        with tempfile.TemporaryDirectory() as tmp:
            root = Path(tmp)