small spelling and grammar fixups to news285#1475
Merged
bitschmidty merged 1 commit intobitcoinops:masterfrom Jan 19, 2024
Merged
small spelling and grammar fixups to news285#1475bitschmidty merged 1 commit intobitcoinops:masterfrom
bitschmidty merged 1 commit intobitcoinops:masterfrom
Conversation
bitschmidty
reviewed
Jan 18, 2024
Contributor
bitschmidty
left a comment
bitschmidty
left a comment
There was a problem hiding this comment.
Noticing a missing period after the lede as well. Will defer to @harding on these other suggestions/updates.
LarryRuane
force-pushed
the
news-285-fixes
branch
from
12690de to
7b38c5e
Compare
Collaborator
Author
|
Good catch, Mike, I force-pushed that fix (add the missing period). |
LarryRuane
force-pushed
the
news-285-fixes
branch
from
7b38c5e to
c8c5139
Compare
Collaborator
Author
|
Force-pushed to resolve merge conflicts with #1476 (podcast timestamps). |
Collaborator
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
ACK except comment on funds
Comment on lines
+264
to
+265
| transactions (HTLC-X transactions). If the funding party doesn't have | ||
| much funds in the channel and if feerates rise, the funding party may | ||
| not be able accept a new incoming payment because they don't have | ||
| many funds in the channel and if feerates rise, the funding party may |
Collaborator
There was a problem hiding this comment.
"Much" seems right to me. Isn’t funds an uncountable noun? Either way, perhaps:
Suggested change
| transactions (HTLC-X transactions). If the funding party doesn't have | |
| much funds in the channel and if feerates rise, the funding party may | |
| not be able accept a new incoming payment because they don't have | |
| many funds in the channel and if feerates rise, the funding party may | |
| transactions (HTLC-X transactions). If the funding party is low on | |
| funds in the channel and if feerates rise, the funding party may |
LarryRuane
force-pushed
the
news-285-fixes
branch
from
c8c5139 to
e4bbbaf
Compare
Collaborator
Author
|
Force-pushed Murch's suggestion, I like that much better than what I suggested, thanks! |
bitschmidty
approved these changes
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1468, I was unavailabale to review pre-merge