PM-26059: Remove CipherKeyEncryption feature flag

[david-livefront]

🎟️ Tracking

PM-26059

📔 Objective

This PR removes the CipherKeyEncryption feature flag from the app.

Note that there is still a server version check for this feature to ensure older servers that do not support the feature do not receive updated ciphers.

[claude]

Claude finished @david-livefront's task in 2m 21s —— View job

---

Re-Review Summary

PR: PM-26059: Remove CipherKeyEncryption feature flag

Previous Findings -- Resolved

Both findings from the initial review have been addressed in the latest commit:

1. Test expected value (FeatureFlagManagerTest.kt line 30): Updated from false to true to reflect that getCipherKeyEncryptionFlagState() now returns true when the server version meets the minimum threshold (fake server "2024.7.0" >= "2024.2.0").

2. KDoc documentation (FeatureFlagManagerImpl.kt line 47): Updated to remove the "remote flag" reference, now accurately reads "based on server version."

Change Assessment

Area	Status
Security	No concerns -- cipher key encryption remains active, only the remote flag gate removed
Correctness	Server version check correctly retained; all FlagKey.CipherKeyEncryption references cleanly removed
Breaking Changes	None -- internal flag removal only
Test Coverage	Tests properly updated across FeatureFlagManagerTest, DebugMenuViewModelTest, and FlagKeyTest
Completeness	All 7 files updated: production code, tests, debug UI, and string resources

No new issues found. Clean feature flag removal.

[github-actions]

Checkmarx One – Scan Summary & Details – d419b1fb-425c-4520-8e2c-b72e128a5151

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.90%. Comparing base (aa23d5e) to head (5c31a80).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6617   +/-   ##
=======================================
  Coverage   85.90%   85.90%           
=======================================
  Files         804      804           
  Lines       57370    57368    -2     
  Branches     8307     8306    -1     
=======================================
- Hits        49284    49283    -1     
  Misses       5203     5203           
+ Partials     2883     2882    -1     

Flag	Coverage Δ
app-data	17.53% <100.00%> (-0.01%)	⬇️
app-ui-auth-tools	20.88% <0.00%> (+<0.01%)	⬆️
app-ui-platform	15.07% <0.00%> (+<0.01%)	⬆️
app-ui-vault	25.79% <0.00%> (+<0.01%)	⬆️
authenticator	6.65% <0.00%> (-0.03%)	⬇️
lib-core-network-bridge	4.29% <0.00%> (+<0.01%)	⬆️
lib-data-ui	0.93% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.