fix(acp): admit trusted workflow wake messages - #3209
Open
matthewrball wants to merge 2 commits into
Open
Conversation
Co-authored-by: Matthew Ball <13823657+matthewrball@users.noreply.github.com> Signed-off-by: Matthew Ball <13823657+matthewrball@users.noreply.github.com>
Author
|
@block/buzz-oss-team Ready for review. This unblocks scheduled owner-scoped agent workflows that are currently dropped by the ACP author gate. All GitHub checks and the local ACP/relay validation in the PR description are green; the trust path fails closed for a missing or mismatched workflow signer. A security-focused review would be appreciated. |
Co-authored-by: Matthew Ball <13823657+matthewrball@users.noreply.github.com> Signed-off-by: Matthew Ball <13823657+matthewrball@users.noreply.github.com>
Author
|
Follow-up commit Fresh validation at this commit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ptag as the owner.ptag while keeping mentioned-agent wake targets.Validation
At
c98ca6a:cargo fmt --all -- --checkcargo clippy -p buzz-acp --all-targets --all-features -- -D warningscargo test -p buzz-acp: 623 unit tests and 9 lifecycle tests passed; doc tests passed.At
e46802ebefore the ACP-only follow-up:cargo clippy -p buzz-acp -p buzz-relay --all-targets --all-features -- -D warningscargo test -p buzz-relay nip11::tests --lib: 15 passed.cargo test -p buzz-relay workflow_sink::tests --lib: 18 passed.test-unit,desktop-test,desktop-build,desktop-tauri-check,desktop-tauri-test, andweb-buildpassed.Known unrelated validation gaps
just cireaches mobile analysis, where Flutter 3.44 reports the existingaxisAlignmentdeprecation inmobile/lib/features/pairing/pairing_page/pairing_welcome_view.dart:114.buzz-relaysuite and isolated pre-existing admin/media database tests hitSqlx(PoolTimedOut)in the local database environment. The changed relay modules pass their focused tests.