Make one-to-one agent DMs implicitly addressed - #3232
Draft
mdeiters wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Matthew Deiters <mdeiters@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ptags from explicitmentionreferences.Buzz adds recipient
ptags to every DM participant for delivery and notifications. The ACP harness previously treated those tags as explicit mentions, so it could not safely distinguish a one-to-one agent DM from a group DM. This change uses signed channel participant metadata and explicit mention-reference tags to make that distinction.Missing or malformed channel metadata fails closed and keeps mention filtering enabled.
Related issue
None found.
Testing
cargo test -p buzz-acp(620 unit tests, 9 integration tests)cargo clippy -p buzz-acp --all-targets -- -D warningscargo fmt --all -- --checkjust ci