Fix/id field non nullable json schema#1118
Open
rossroberts-toast wants to merge 3 commits intoblock:mainfrom
Open
Fix/id field non nullable json schema#1118rossroberts-toast wants to merge 3 commits intoblock:mainfrom
rossroberts-toast wants to merge 3 commits intoblock:mainfrom
Conversation
The Goose docs moved from block.github.io/goose to goose-docs.ai, causing a 404 in the HTML-Proofer CI check.
rossroberts-toast
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwils,
jwondrusch and
myronmarston
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to ensure that the required ID field in the json schema of any top level document is non-nullable. This should resolve the bug raised here: #1117