feat: add isAggregator flag to validator configuration#108
feat: add isAggregator flag to validator configuration#108ch4r10t33r wants to merge 2 commits intomainfrom
Conversation
Add support for configuring nodes as aggregators through validator-config.yaml. This allows selective designation of nodes to perform aggregation duties by setting isAggregator: true in the validator configuration. Changes: - Add isAggregator field (default: false) to all validators in both local and ansible configs - Update parse-vc.sh to extract and export isAggregator flag - Modify all client command scripts to pass --is-aggregator flag when enabled - Add isAggregator status to node information output
| --log-level debug \ | ||
| --hash-sig-key-dir $configDir/hash-sig-keys" | ||
| --hash-sig-key-dir $configDir/hash-sig-keys \ | ||
| $aggregator_flag" |
There was a problem hiding this comment.
node is not an agrregator based on the flag but based on the validator id which is an aggregator which is parsed via the validator-config to annotated_validaors.yaml
but the main question is how do we assign aggregator to the validator of which of the nodes.
the solution for that is: all the nodes who want to run the aggregator as reflected via validator-config, one of their validator ids need to be picked and flagged true as ggregator in anootated validators
also validator-config needs to now carrynum subnets, which will also need to be inserted in config.yaml
for now this number is 1
There was a problem hiding this comment.
Yes, but this flag is determined/initialised from the validator-config.yaml. Having said that, this PR is still in draft and I am waiting for the zeam PR to be merged before I can work and complete this.
951526d to
c571bc7
Compare
Summary
Add support for configuring nodes as aggregators through validator-config.yaml. This allows selective designation of nodes to perform aggregation duties by setting
isAggregator: truein the validator configuration.Changes
isAggregatorfield (default:false) to all validators in both local and ansible configsparse-vc.shto extract and exportisAggregatorflag--is-aggregatorflag when enabledisAggregatorstatus to node information output inparse-vc.shUsage
To designate a node as an aggregator, simply set
isAggregator: truein the validator-config.yaml:The
spin-node.shscript will automatically detect this configuration and pass the--is-aggregatorflag to the client.Test plan
isAggregator: falsestart without the--is-aggregatorflagisAggregator: truereceive the--is-aggregatorflag