Draft
Conversation
Since attestation_committee_count is now hardcoded in clients, make it optional: - Only pass --attestation-committee-count flag if explicitly set in config - Remove default value from validator-config.yaml files - Clients will use their hardcoded default if flag not provided
Contributor
|
Do we need to add the defined number of committees into the config file? It's mentioned in the specs here. |
Contributor
Author
ATM, the attestation_committee_count is hardcoded in the spec as 1. I had made it configurable in my devnet3 PR. So yes, I think its a good idea to add it to the config file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for configuring attestation committee count and automatic aggregator selection for devnet3.
Key Features
1. Attestation Committee Count Configuration
attestation_committee_countparameter invalidator-config.yaml(default: 1)--attestation-committee-countflagconfigsection2. Automatic Aggregator Selection
--aggregator <node_name>flag to specify which node should be the aggregatorisAggregatorflag invalidator-config.yamlbefore starting nodes--is-aggregatorflag when designated as aggregator3. Enhanced Configuration Management
isAggregatorfield added to all validators in both local and ansible configsparse-vc.shextracts and exports bothisAggregatorandattestationCommitteeCountvalues