Simplify executor implementations#4891
Merged
nekevss merged 4 commits intoboa-dev:mainfrom Mar 6, 2026
Merged
Conversation
dce10ee to
3627df9
Compare
This was referenced Mar 6, 2026
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4891 +/- ##
===========================================
+ Coverage 47.24% 57.29% +10.05%
===========================================
Files 476 556 +80
Lines 46892 60623 +13731
===========================================
+ Hits 22154 34734 +12580
- Misses 24738 25889 +1151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After seeing the avalanche of issues that our executors have, I don't think it's worth being too smart about when to exit the loop. Folks who wanna have that behaviour can just implement their own
JobExecutor.Thus, this reverts the implementation to the old behaviour of blocking when having pending timeout and interval jobs. Fortunately,
run_jobs_asyncexists, so we can use it in our CLI to intersperse executing jobs with executing parsing and execution.And just for good measure, it also adds a
stopcancellation token toSimpleJobExecutor, in case folks still want to use it but that also want to remotely stop the event loop's execution from another thread.