Rebecca Noy (non working state)#87
Draft
extra-jalapenos wants to merge 36 commits intoboolean-uk:mainfrom
Draft
Conversation
Auenc
reviewed
Jan 31, 2024
| const token = await generateToken(payload) | ||
| console.log(token) | ||
| res.status(200).json({ | ||
| message: `logged in user ${username, |
There was a problem hiding this comment.
I did not know you could use injection with multiple variables!
Auenc
reviewed
Jan 31, 2024
| const user = await createUserDb(req, res) | ||
| if (user) res.status(201).json({ success: `User ${username} created`}) | ||
| } catch (error) { | ||
| if (error instanceof PrismaClientKnownRequestError) { |
There was a problem hiding this comment.
Nice to see you narrowing down the error type
Auenc
reviewed
Jan 31, 2024
| try { | ||
| return jwt.verify(webtoken, secret) | ||
| } catch (error) { | ||
| return false |
There was a problem hiding this comment.
Better to actually let the error throw here (or throw your own custom error). Just returning false, you lose some of the error information. False tells us that the token wasn't valid, but it doesn't tell us why the token wasn't valid. Is it malformed? is it expired? etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.