Skip to content

Pierluigi#88

Open
PCapid3v wants to merge 5 commits intoboolean-uk:mainfrom
PCapid3v:main
Open

Pierluigi#88
PCapid3v wants to merge 5 commits intoboolean-uk:mainfrom
PCapid3v:main

Conversation

@PCapid3v
Copy link
Copy Markdown

No description provided.

Comment thread src/client/App.jsx
const handleRegister = async ({ username, password }) => {

try {
const res = await fetch(`${apiUrl}/user/register`, {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you're making multiple post calls to the API - it would be a good idea to create a helper function that does the post call for you (and creates the options object) that your register/login functions can just call

Copy link
Copy Markdown

@Auenc Auenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants