Skip to content

Eduard#89

Open
EwbiDev wants to merge 52 commits intoboolean-uk:mainfrom
EwbiDev:freedom
Open

Eduard#89
EwbiDev wants to merge 52 commits intoboolean-uk:mainfrom
EwbiDev:freedom

Conversation

@EwbiDev
Copy link
Copy Markdown

@EwbiDev EwbiDev commented Jan 29, 2024

No description provided.

@EwbiDev EwbiDev marked this pull request as draft January 29, 2024 09:32
@EwbiDev EwbiDev marked this pull request as ready for review January 30, 2024 18:34
* @param {{}} payload
* @returns {Promise<Object>}
*/
async function postUrl(endpoint, payload) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really small nitpick, but I'm not quite sure what the url portion of the function name gives us. I think just calling the function post would be better

* @param {Types.ExResponse} res
* @param {Types.ExNext} next
*/
async function validateLoginSession(req, res, next) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of middleware

@@ -0,0 +1,11 @@
import { z } from "zod";

const submitMovieSchema = z
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see you using zod

Copy link
Copy Markdown

@Auenc Auenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants