Callum#91
Open
Callumhayden99 wants to merge 3 commits intoboolean-uk:mainfrom
Open
Conversation
Auenc
reviewed
Feb 1, 2024
|
|
||
| const handleRegister = async ({ username, password }) => { | ||
| try { | ||
| const response = await fetch(`http://localhost:4000/user/register`, { |
There was a problem hiding this comment.
As you're making multiple post requests it would be good if you made a helper function so that you don't have to keep creating the objects object/duplicate the request code
Auenc
reviewed
Feb 1, 2024
| const prisma = new PrismaClient(); | ||
|
|
||
| const jwtSecret = 'mysecret'; | ||
| const jwtSecret = "mysecret"; |
There was a problem hiding this comment.
jwt secrets are usually best kept in the .env file
Auenc
reviewed
Feb 1, 2024
| return res.status(401).json({ error: 'Invalid username or password.' }); | ||
| if (passwordsMatch) { | ||
| const token = jwt.sign({ username: foundUser.username }, jwtSecret, { | ||
| expiresIn: "24h", |
There was a problem hiding this comment.
expiresIn is also a good candidate for an environment variable so that we don't have to change code to change how long a token exists for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.