Do not extend the pool on each allocation#55
Open
orgads wants to merge 1 commit intoboostorg:developfrom
Open
Conversation
orgads
force-pushed
the
no-extend
branch
4 times, most recently
from
10969c8 to
e231843
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #55 +/- ##
===========================================
- Coverage 93.71% 93.69% -0.03%
===========================================
Files 9 9
Lines 589 587 -2
===========================================
- Hits 552 550 -2
Misses 37 37
Continue to review full report in Codecov by Sentry.
|
jeking3
requested changes
Jan 3, 2025
Collaborator
jeking3
left a comment
jeking3
left a comment
There was a problem hiding this comment.
Rebase on current develop for a full CI suite run.
Reported in Boost mailing list: https://lists.boost.org/Archives/boost/2023/06/254750.php Commit 951ca57 changed malloc_need_resize() to use set_next_size(), which sets start_size in addition to setting next_size. this causes repeated use of purge_memory() to allocate 2x size after every use. Fixes boostorg#54
Contributor
Author
|
Rebased. |
Contributor
Author
|
The failure is due to quota limit on codecov, unrelated to my change. |
|
Will this come in any time soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported in Boost mailing list: https://lists.boost.org/Archives/boost/2023/06/254750.php
Commit 951ca57 changed malloc_need_resize() to use set_next_size(), which sets start_size in addition to setting next_size. this causes repeated use of purge_memory() to allocate 2x size after every use.
Fixes #54