Story 2385: Integrate Community Page Links#2402
Conversation
962755c to
1621dac
Compare
julhoang
left a comment
There was a problem hiding this comment.
Hi @herzog0 ! This is looking great. I'm just mainly requesting change to exclude deleted posts from the Entry query and add the ability to pin library in the Library Card 🙏
I also have a general question – what should be our mental model for where to declare the text copies? Should HTML templates own those text declarations and the context only supply dynamic data? If that's the case, perhaps the most of the data for ctx["help_options"] can be declared in the _help_card, just except the URLs? 🤔
jlchilders11
left a comment
There was a problem hiding this comment.
Couple of small things, and expanding on some comments Julia made. Looks good otherwise!
julioest
left a comment
There was a problem hiding this comment.
UI looks great. Pre-approving
05ba75f to
e20ebf7
Compare
jlchilders11
left a comment
There was a problem hiding this comment.
This looks good to me, thanks for addressing my feedback!
257a1ce to
5aed6bb
Compare
| baker.make( | ||
| "libraries.LibraryVersion", | ||
| library=baker.make("libraries.Library", name=f"lib-{i}"), | ||
| library=baker.make("libraries.Library", name=f"lib-{i}", slug=f"lib-{i}"), |
There was a problem hiding this comment.
Don't bother with this. My previous deployment got lucky and ran into a slug key collision. Random suffixes are added in libraries/models.py line 359, and if the slug prefix is None (which used to be the case in this line I'm editing) we got a small chance of collision. Re-running the job fixed it, but I'm adding this just so it doesn't happen again.
feat: fetch flagship libraries from database for community page discover section feat: fetch recent published entries from database for community page posts section fix: wire CTA URLs for contributing, libraries listing, and posts feed feat: add dynamic year/month URL for mailing list recent threads card refactor: build all CTA URLs in the view using request.build_absolute_uri fix: build contribute_url dynamically using request host
… version fix: filter community page libraries by selected Boost version using Exists subquery
Removes duplicate version-resolution logic; both now share a single source of truth from context_processors.selected_version().
Replaces the inline get_version_from_cookie call with context_processors.selected_version() so redirect-target resolution shares a single source of truth with the rest of the version pipeline.
53be7e5 to
80ac7ff
Compare
Issue: #2385
Summary & Context
This PR integrates the Community Page with backend data, fixing all CTA and Link URLs and adjusting some minor copy text.
http://localhost:8000/community/Changes
core/views.pyto pull data from the database instead of mocked data;v3/community.htmlto ssr some CTA links;_thread_archive_card.htmlto accept url arguments;Testing pinned libraries
Screenshots
Self-review Checklist
Frontend