BST-14399: add additional includes for complete docker proxy#19
Merged
Jonathan Serafini (JonathanSerafini) merged 2 commits intomainfrom Apr 24, 2025
Merged
BST-14399: add additional includes for complete docker proxy#19Jonathan Serafini (JonathanSerafini) merged 2 commits intomainfrom
Jonathan Serafini (JonathanSerafini) merged 2 commits intomainfrom
Conversation
Jonathan Serafini (JonathanSerafini)
marked this pull request as ready for review
Jonathan Serafini (JonathanSerafini)
requested a review
from a team
as a code owner
Victor Barroncas (victor-nb)
previously approved these changes
Apr 14, 2025
Jonathan Serafini (JonathanSerafini)
requested a review
from Victor Barroncas (victor-nb)
Contributor
Author
|
Victor Barroncas (@victor-nb) upgraded docker to v28 |
Jake Bédard (Clearedkinkajou)
approved these changes
Apr 24, 2025
Victor Barroncas (victor-nb)
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in order to ensure that all docker images use the optional docker registry proxy
additional includes are added which will be conditionally loaded by the ci pipeline file.
ideally, scanner.yaml would have contained all of this logic, however gitlab does not
allows environment variable interpolation on a nested include.
the change should be backwards compatible