devcontainer: Also add all caps, fix CI flow

[cgwalters]

This is needed for nested containerization.

And the CI flow should not be recreating the devcontainer json,
it should be actually testing what we have.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the devcontainer configuration to include the CAP_SYS_ADMIN capability. This critical addition facilitates advanced containerization scenarios, specifically enabling nested Podman instances, thereby ensuring a fully functional and robust development environment for users.

Highlights

• Devcontainer Configuration: Added the CAP_SYS_ADMIN capability to the capAdd property in devcontainer.json. This is essential for enabling nested containerization, such as running Podman, within the development environment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• common/.devcontainer/devcontainer.json
  • Added CAP_SYS_ADMIN to the capAdd array.
  • Included a comment explaining the purpose of capAdd for nested containerization.

Activity

• The author identified and addressed a previously missed, but necessary, capability (CAP_SYS_ADMIN) for the devcontainer setup.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds the CAP_SYS_ADMIN capability to the devcontainer configuration. While this may be necessary for nested containerization, it introduces a significant security risk by granting extensive privileges to the container. My primary feedback is to reconsider if this broad capability is essential or if a more fine-grained set of permissions could be used. I've also suggested a minor improvement to a code comment for better clarity.

_{Note: Security Review has been skipped due to the limited scope of the PR.}