This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Add Basic Auth capability to ImportJSONViaPost and add Bearer Auth request#218
Open
benblaine wants to merge 1 commit intobradjasper:masterfrom
Open
Add Basic Auth capability to ImportJSONViaPost and add Bearer Auth request#218benblaine wants to merge 1 commit intobradjasper:masterfrom
benblaine wants to merge 1 commit intobradjasper:masterfrom
Conversation
I added code to `ImportJSONViaPost` to handle username and password parameters for Basic Auth requests and I added a function `ImportJSONBearerAuth` to handle bearer auth requests
DONALDSULLENDER
approved these changes
Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added code to
ImportJSONViaPostto handle username and password parameters for Basic Auth requests and I added a functionImportJSONBearerAuthto handle bearer auth requests.I considered creating a new function
ImportJSONBasicAuthViaPostwhich would pass the basic auth params toImportJSONViaPostbut I couldn't get it right so gave up and just put the code insideImportJSONViaPost.Thanks to @christales (https://github.com/christales) for help here: #215
Also to help from @idfurw on Stackoverflow here