Feat/placa renavam#138
Closed
eduardo-fernandes-marques wants to merge 4 commits intobrazilian-utils:mainfrom
Closed
Feat/placa renavam#138eduardo-fernandes-marques wants to merge 4 commits intobrazilian-utils:mainfrom
eduardo-fernandes-marques wants to merge 4 commits intobrazilian-utils:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 52 +2
Lines 932 963 +31
Branches 111 117 +6
=========================================
+ Hits 932 963 +31 ☔ View full report in Codecov by Sentry. |
hyanmandian
requested changes
Aug 28, 2020
Member
hyanmandian
left a comment
hyanmandian
left a comment
There was a problem hiding this comment.
Nice job @eduardo-fernandes-marques !
hyanmandian
reviewed
Aug 28, 2020
hyanmandian
reviewed
Aug 28, 2020
Member
|
Ola @eduardo-fernandes-marques acabamos de mergear #158 que tem a ver com o teu e notamos uma divergencia de implementações, queria ver contigo se tu ve algo a acrescentar já que o teu possui mais implementações do que o código que foi mergeado. |
Member
|
Fala @eduardo-fernandes-marques meu querido! So pra avisar, to fazendo um refactoring da lib e vou incluir seu PR la! #398 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adicionado features de validação:
Renavam
Placa de veículo (Carro, Carro Mercosul, Moto Mercosul)