Add self-modifying harness docs and edge-case benchmark#335
Open
MagMueller wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/edge-case-benchmark.html">
<violation number="1" location="docs/edge-case-benchmark.html:323">
P2: The coordinate task can be passed via synthetic/programmatic click events, so it does not reliably enforce a real coordinate-driven pointer action.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| } | ||
| }); | ||
|
|
||
| document.getElementById("coordinate-target").addEventListener("click", () => { |
Contributor
There was a problem hiding this comment.
P2: The coordinate task can be passed via synthetic/programmatic click events, so it does not reliably enforce a real coordinate-driven pointer action.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/edge-case-benchmark.html, line 323:
<comment>The coordinate task can be passed via synthetic/programmatic click events, so it does not reliably enforce a real coordinate-driven pointer action.</comment>
<file context>
@@ -0,0 +1,328 @@
+ }
+ });
+
+ document.getElementById("coordinate-target").addEventListener("click", () => {
+ setPass("coordinate", "red target clicked");
+ });
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/edge-case-benchmark.htmlpage that exercises those four mechanics and exposeswindow.edgeBenchmark.resultsValidation
python3HTML parser accepteddocs/edge-case-benchmark.html/tmp/browser-harness-edge-benchmark-result.pngenv -u BU_CDP_URL -u BU_CDP_WS uv run --with pytest pytest -q tests/unit-> 77 passedPass/fix notes from benchmark run
upload_file()plus explicitinput/changeeventsDataTransferhelperclick_at_xy()about:blankviadocument.write()Summary by cubic
Adds a self-modifying harness guide and a standalone browser benchmark to validate canvas signatures, uploads, drag-and-drop, and coordinate-only targets. The benchmark exposes
window.edgeBenchmark.resultsfor quick automated checks.docs/self-modifying-harness.md: explains the inspect → patch → retry → verify loop with four edge-case walkthroughs.docs/edge-case-benchmark.html: exercises the four mechanics and exposeswindow.edgeBenchmark.resultsfor verification.README.mdto link the new docs and benchmark.Written for commit a9a6977. Summary will update on new commits.