Closed
Conversation
There was a problem hiding this comment.
2 issues found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/src/main/hl/streamToTerm.ts">
<violation number="1" location="app/src/main/hl/streamToTerm.ts:139">
P2: Handle embedded newlines before `\x1b[K`; multi-line prompts only get the full-width background on the last line.</violation>
</file>
<file name="app/src/renderer/hub/TerminalPane.tsx">
<violation number="1" location="app/src/renderer/hub/TerminalPane.tsx:201">
P2: Prevent the idle spinner from starting before terminal replay is applied; otherwise spinner frames can race with replay rendering and overwrite visible replay content.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dots2, 8 frames @ 80ms) renders in the xterm grid while the agent is running but no bytes have arrived for 250ms — fills the dead time between a user prompt and the first thinking delta, or between atool_calland the next eventclaude-code→ Anthropic orange,codex→ blue,browsercode/default → off-white\r\x1b[2Kso it never grows scrollback or overlaps content; cleared in place when real bytes arrive or when the session leaves therunningstate›rows) now render with a subtle slate background (#1c2634) extended to end-of-line via\x1b[K, with white text instead of bright cyan so the bg highlight reads as a banded row rather than a colored spanTest plan
tool_resultand the next thinking rundoneorstoppedSummary by cubic
Add an inline “thinking” spinner to xterm logs and a subtle highlight for user prompts to improve feedback during idle gaps. The spinner starts after 250ms of silence, only after the initial replay renders, and clears immediately when bytes stream in or the session stops.
claude-code(orange),codex(blue), default/browser (off-white).TerminalPaneacceptsengineandisActive;LogsApppassessession.engineand status so the spinner only shows while running and after replay.Written for commit 1578673. Summary will update on new commits.