Skip to content

Update dependencies#49

Open
ahmedyarub wants to merge 2 commits intobrunomnsilva:masterfrom
ahmedyarub:ay/update_dependencies
Open

Update dependencies#49
ahmedyarub wants to merge 2 commits intobrunomnsilva:masterfrom
ahmedyarub:ay/update_dependencies

Conversation

@ahmedyarub
Copy link
Copy Markdown

This has already been tested

@andrej-urvantsev
Copy link
Copy Markdown

andrej-urvantsev commented Apr 2, 2026

This should probably be closed: This PR is some kind of super-low effort thing. It changes Java compatibility level to 25, updates JavaFx to 26 early access and apparently changes project version itself ?..

@ahmedyarub
Copy link
Copy Markdown
Author

This should probably be closed: This PR is some kind of super-low effort thing. It changes Java compatibility level to 25, updates JavaFx to 26 early access and apparently changes project version itself?..

JavaFX 26 is already releases. I can change the version from EA to GA. Are you OK with that? JavaFX 26 requires JDK 25.

@andrej-urvantsev
Copy link
Copy Markdown

I'm not a maintainer and @brunomnsilva probably can answer better, but as a user I can't jump to the latest JavaFx just because some library decides so.

There must be a strategy about changing language level and minimal JavaFx version, but I would personally stick to the latest LTS at least.

For JavaFx it's 25 and 21 respectively, but it's again maintainers choice.

Also, instead of

<source>${java.version}</source>
<target>${java.version}</target>

in maven compiler plugin it's better to use

<release>${java.version}</release>

And I was wrong about project version in the previous comment - you've updated smartgraph dependency, which might OK I guess.

@andrej-urvantsev
Copy link
Copy Markdown

Err.. no, I wasn't wrong - "smartgraph" is a project artifact version. You shouldn't change that version, it usually changed during release.

@ahmedyarub
Copy link
Copy Markdown
Author

Appreciate the advice. I changed the version to include it as a submodule in one of my projects. The version number should be fixed before merging, as you mentioned above. Let's see whether the maintainer is interested in this PR. Otherwise, I'll just maintain my own fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants