chore: revert "mongo: fold constant arithmetic expressions with JavaScript semantics (#393)" - #396
Merged
Merged
Conversation
With the constant-folding revert, the BYT-9950 statement fails to parse again; the strict Parse contract now guarantees the error is surfaced instead of the statement being silently dropped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
h3n4l
changed the title
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverts #393 (constant arithmetic folding in the mongo parser), which was merged unexpectedly. Arithmetic expressions such as
expireAfterSeconds: 90 * 24 * 60 * 60are parse errors again.The strict-
Parsetest from #395 that asserted the BYT-9950 statement parses is flipped to pin the intended behavior instead: the statement fails with aParseError, which strictParsesurfaces rather than silently dropping the statement.Consumer impact
arith_fold_test.goand theexpression.gofolding paths cleanly (git revert, no conflicts).Testing
go test ./mongo/...passes.🤖 Generated with Claude Code