fix: signature lowering for strings and lists on modules with 64bit memory#2544
Open
christoph-dfinity wants to merge 3 commits into
Open
fix: signature lowering for strings and lists on modules with 64bit memory#2544christoph-dfinity wants to merge 3 commits into
christoph-dfinity wants to merge 3 commits into
Conversation
0a95a3d to
5a6e229
Compare
5a6e229 to
71a4eb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes signature lowering for strings and lists on modules with 64bit memory.
Before this change the newly added tests fail with a signature mismatch, because the lowering unconditionally produced i32 pointers and lengths. On modules with 64bit memories these need to be i64 instead, based on my reading of the Canonical ABI document
Before the fix the tests fail with:
/cc @michael-weigelt