test: add tvOS platform command coverage manifest - #1919
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. |
Review — approve with two asks (neither changes the classification)Read the full manifest and gate against the #1426 ground rules; also verified the wiring and the grouped gap issue independently. What's right, and verified:
Ask 1 — the summary builder just became a third copy. Ask 2 — planted-red proof, one sentence. The exhaustiveness One nit, no action needed: the hardcoded counts assertion (3/12/39/0/54) doubles as the "coverage report" acceptance artifact and will need a bump whenever a command is added or a gap closes — that friction looks intentional (it forces the manifest to be revisited), just confirming it's understood rather than accidental. |
|
Addressed the summary-builder ask in the PR body: this tvOS PR stays platform-scoped, and the macOS coverage-manifest PR is explicitly assigned to factor the pure builder into test/integration/support/ before adding the fourth copy. The planted-red proof is also recorded in the Validation section. |
|
The required Integration Tests lane is red because the manifest records |
|
Fixed in follow-up commit 44e92a4 and pushed. The hosted Integration Tests failure showed that audio is denied on CI but host-dependent on Darwin; the manifest now records audio as capability-denial, pins 4 denials / 38 gaps, and the gate asserts Darwin admission separately. Focused tvOS gate and pnpm check:affected --run pass locally. Issue #1914 was updated to remove audio from its gap list. |
|
[P1] Keep the capability oracle total. On Darwin, |
|
Addressed the P1 in follow-up commit 8611dcf and pushed. Audio is now a host-dependent command-contract row backed by the existing tvOS-inclusive capability parity test; the gate compares the full oracle and projects the declared host-dependent admission instead of filtering audio. Counts are now 3 denials / 13 contracts / 38 gaps. Local focused and affected gates pass. |
|
Re-reviewed |
|
Follow-up: iOS Smoke completed successfully on |
|
Summary
Record<PublicCommand, ...>for all 54 public commands.Validation
Evidence gathered at commit
8611dcfde:pnpm check:quick, and the fullpnpm check:affected --runcompleted successfully; all runnable checks passed.artifactsrow failed catalog completeness and changed the report to 53 total / 38 gaps; restoring it returned all 7 gate tests to green.audiois now a command-contract row backed by the existing exhaustive tvOS-inclusive capability parity test. The gate restores full oracle parity and projects the declared host-dependent admission; the pinned report is 3 denials / 13 contracts / 38 gaps.Follow-up
The coverage summary builder remains local to each platform manifest to keep this tvOS change platform-scoped and avoid introducing a shared row type. The macOS coverage-manifest PR should factor the pure summary builder into
test/integration/support/before adding the fourth copy; this PR's count assertion keeps tvOS command additions explicit.Touched files: 2, tvOS-only. Docs/help/skills were unchanged because this is a test-coverage manifest and no command behavior changed.