refactor: split daemon client facade#773
Open
thymikee wants to merge 1 commit into
Open
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
src/daemon-client.tsinto a 181 LOC facade while preserving its public export surface and request orchestration behavior.Architecture boundaries:
src/daemon-client-lifecycle.tssrc/daemon-client-metadata.tssrc/daemon-client-transport.tssrc/daemon-client-rpc.tssrc/daemon-client-timeout.tsTouched files: 7. The fallow health baseline only moves/reduces the existing daemon-client path allowance from the old file to the new focused modules.
Closes #727
Validation
Focused daemon-client unit coverage passed:
pnpm exec vitest run --project unit src/utils/__tests__/daemon-client.test.ts src/utils/__tests__/daemon-client-lifecycle.test.ts src/__tests__/daemon-client-progress.test.ts.Remote provider scenario command loaded successfully but both loopback-backed cases skipped in this environment:
pnpm exec vitest run --project provider-integration test/integration/provider-scenarios/remote-daemon-client.test.ts.Static/build gates passed:
pnpm format,pnpm check:quick,pnpm check:fallow --base origin/main, andpnpm build.