ci: stabilize E2E tests, speed up Android CI, pin actions#388
Open
artus9033 wants to merge 12 commits into
Open
ci: stabilize E2E tests, speed up Android CI, pin actions#388artus9033 wants to merge 12 commits into
artus9033 wants to merge 12 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce flakiness in Detox E2E tests by centralizing timing budgets, adding a “reload RN with sync disabled” recovery helper, and using those utilities in AppleApp E2E flows to avoid hangs when RN debug surfaces keep the app non-idle.
Changes:
- Added shared Detox timing constants (
DETOX_TIMING) and reused them for polling/timeout budgets. - Introduced
reloadReactNativeIgnoringSync()to reload RN without waiting for app idleness. - Refactored AppleApp Detox helpers to scroll embedded RN into view and use the new reload + timing utilities.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/brownfield-example-shared-tests/e2e/detoxUtils.cjs | Adds sync-ignoring RN reload helper and replaces hardcoded polling delay with shared timing constant. |
| apps/brownfield-example-shared-tests/e2e/detoxTiming.cjs | Introduces centralized timing constants for E2E waits/polling/timeouts. |
| apps/brownfield-example-shared-tests/e2e/createDetoxJestConfig.cjs | Uses centralized test timeout from DETOX_TIMING. |
| apps/brownfield-example-shared-tests/e2e/appleAppDetoxUtils.cjs | Updates AppleApp E2E utilities to scroll + wait using shared timeouts and reload with sync disabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
artus9033
changed the title
artus9033
changed the title
artus9033
changed the title
Comment on lines
+18
to
+23
| brownfieldE2E, | ||
| }: RNAppProps) { | ||
| useEffect(() => { | ||
| syncBrownfieldE2EModeFromRootProps({ brownfieldE2E }); | ||
| return () => syncBrownfieldE2EModeFromRootProps(undefined); | ||
| }, [brownfieldE2E]); |
Comment on lines
17
to
22
| @@ -14,11 +18,11 @@ runs: | |||
| uses: actions/setup-node@65d868f8d4d85d7d4abb7de0875cde3fcc8798f5 # v6 | |||
| with: | |||
| node-version: 'lts/*' | |||
| cache: 'yarn' | |||
| cache: ${{ inputs.disable-cache != 'true' && 'yarn' || '' }} | |||
|
|
|||
…e, rename disable-cache to gradle-cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
Test plan
CI green (few consecutive re-runs of E2E succeed).