fix(ios): restore VoiceOver increment/decrement on Fabric - #825
Open
kosmydel wants to merge 1 commit into
Open
Conversation
RCTViewComponentView treats contentView as the a11y leaf, so the Fabric wrapper stole UISlider's Adjustable trait. Point VoiceOver at the inner slider instead. Co-authored-by: Cursor <cursoragent@cursor.com>
kosmydel
marked this pull request as ready for review
August 26, 2026 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On Fabric,
RNCSliderComponentViewhostsUISliderascontentView.RCTViewComponentViewtreats that as the accessibility leaf, so VoiceOver focuses the wrapper instead of the slider. The wrapper is a plainUIViewand does not implement increment/decrement, which drops UISlider's Adjustable trait.This matches React Native's own text-input pattern: the host is not an accessibility element, and
accessibilityElementpoints at the inner control.Test Plan:
accessibilityLabel(no customaccessibilityValue).Expo example
App.tsx