Conversation
Update to the latest version
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary
This PR updates dependencies and adds --nodejs flags to test commands. I identified three substantive issues with dependency optional/dev flags being inconsistently changed in package-lock.json (once, safer-buffer, wrappy), which could cause installation or runtime issues. The test changes adding --nodejs flags appear intentional for compatibility with newer CDS versions.
PR Bot Information
Version: 1.17.61 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback
- Correlation ID:
0803f3f0-109e-11f1-926e-bc53b7b884e1 - LLM:
anthropic--claude-4.5-sonnet - Event Trigger:
pull_request.opened
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Dependencies and Simplify Configuration Templates
♻️ Refactor
Updated project dependencies and simplified configuration template handling for application metadata.
Changes
package.json: Updated development dependenciesnycfrom^17to^18sinonfrom^20to^21files/runtime-values.yaml.hbs: Simplified template expressions by removing parentheses wrapper around application name and description placeholdersTest Files: Standardized test setup across multiple test files by explicitly adding
--nodejsflag tocds initcommandstest/add-check.test.jstest/add-services.test.jstest/add.test.jstest/build-services.test.jstest/build.test.jstest/cap-op-plugin.test.jsExpected Test Fixtures: Updated expected output files to reflect the simplified template format
test/files/expectedChart/runtime-values-ias.yamltest/files/expectedChart/runtime-values.yamltest/files/expectedConfigurableTemplatesChart/runtime-values-ias.yamltest/files/expectedConfigurableTemplatesChart/runtime-values.yamltest/files/runtime-values-of-simple-chart.yamlThe changes standardize the test environment setup and remove unnecessary template syntax from configuration files, improving maintainability while keeping functionality intact.
📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!
PR Bot Information
Version:
1.17.61| 📖 Documentation | 🚨 Create Incident | 💬 Feedback66b42a30-10be-11f1-8634-c11be0f74b88issue_comment.edited