Skip to content

Conversation

@c43721
Copy link

@c43721 c43721 commented Apr 29, 2022

First of all, thank you for your contribution! 😄

Please make sure you have read contribution guidelines.

Most important items

  • Make sure to communicate your proposed changes ob our Slack channel beforehand.
  • Large PRs (50+ lines of code) will get rejected due to increased difficulty for review - unless they have been communicated beforehand with project maintainers.
  • Refactoring work will get rejected unless it's been communicated with project's maintainers beforehand. There is a thousand ways to write the same code. Every time a code is changed, there is a potential for a new bug. We don't want to refactor the code just for the sake of refactoring.

These rules are strictly enforced to make sure that we can maintain the project moving forward.

This was duplicated in the package.json, resulting in the build having typescript as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant