chore: modernize Netdata installation to use static binaries #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace git clone + compile approach with pre-built static binaries - Add NETDATA_VERSION build argument for easier version management - Improve Dockerfile structure with clear sections and better formatting - Update build.sh to use Docker Buildx for multi-architecture support - Add logging directory creation before symlinking to stdout/stderr - Clean up unnecessary build dependencies and reduce image size This change improves build reliability and speed by using official static binaries instead of compiling from source during image build.
Contributor
githubsaturn
left a comment
githubsaturn
left a comment
There was a problem hiding this comment.
Thanks for the attempt to fix. But there are multiple issues with this PR. Also, I am not sure why a version bump of Netdata requires some surgical changes in the build and push script. The rootcause must be something else.
| rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* | ||
|
|
||
| ENV DEBIAN_FRONTEND=noninteractive | ||
| RUN apt update && apt full-upgrade -y && chmod +x /run.sh /build.sh && sync && sleep 1 && /build.sh |
Contributor
There was a problem hiding this comment.
build.sh reference is removed from Dockerfile. So it's not called anymore?!
| echo "==========================================" | ||
|
|
||
| # Setup QEMU for multi-arch builds | ||
| docker run --rm --privileged multiarch/qemu-user-static --reset -p yes |
Contributor
There was a problem hiding this comment.
This is duplicated in build_and_push.sh...
Contributor
|
Okay, so I reverted the PR and the build still fails. Somewhat of a good sign... It's not the version upgrade that broke the build, but it's the fact that it's too old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes the Netdata installation process by switching from source compilation to using pre-built static binaries.
Changes
Dockerfile improvements:
NETDATA_VERSIONbuild argument for easier version managementBuild script updates:
scripts/build.shto use Docker Buildx for multi-architecture supportBenefits